chore(telemetry): configuration telemetry reporting #11115

P403n1x87 · 2024-10-22T12:25:49Z

We refactor the implementation of the telemetry configuration reporting to use new API exposed by the latest release of envier. We also implement a configuration class that automatically reports configuration telemetry after the environment variables have been parsed and validated.

Checklist

PR author has checked that all the criteria below are met
The PR description includes an overview of the change
The PR description articulates the motivation for the change
The change includes tests OR the PR description describes a testing strategy
The PR description notes risks associated with the change, if any
Newly-added code is easy to change
The change follows the library release note guidelines
The change includes or references documentation updates if necessary
Backport labels are set (if applicable)

Reviewer Checklist

Reviewer has checked that all the criteria below are met
Title is accurate
All changes are related to the pull request's stated goal
Avoids breaking API changes
Testing strategy adequately addresses listed risks
Newly-added code is easy to change
Release note makes sense to a user of the library
If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
Backport labels are set in a manner that is consistent with the release branch maintenance policy

We refactor the implementation of the telemetry configuration reporting to use new API exposed by the latest release of envier. We also implement a configuration class that automatically reports configuration telemetry after the environment variables have been parsed and validated.

github-actions · 2024-10-22T12:26:17Z

CODEOWNERS have been resolved as:

.riot/requirements/1f27343.txt                                          @DataDog/apm-python
.riot/requirements/22104c1.txt                                          @DataDog/apm-python
.riot/requirements/bd5e098.txt                                          @DataDog/apm-python
ddtrace/settings/_telemetry.py                                          @DataDog/apm-core-python
ddtrace/settings/peer_service.py                                        @DataDog/apm-core-python
hatch.toml                                                              @DataDog/python-guild
lib-injection/sources/min_compatible_versions.csv                       @DataDog/apm-core-python
min_compatible_versions.csv                                             @DataDog/apm-core-python
pyproject.toml                                                          @DataDog/python-guild
riotfile.py                                                             @DataDog/apm-python
tests/telemetry/test_writer.py                                          @DataDog/apm-python
.riot/requirements/1215c62.txt                                          @DataDog/apm-python
.riot/requirements/17cd03c.txt                                          @DataDog/apm-python
.riot/requirements/1842297.txt                                          @DataDog/apm-python
.riot/requirements/19a8ed0.txt                                          @DataDog/apm-python
.riot/requirements/1c89113.txt                                          @DataDog/apm-python
.riot/requirements/1dcfbb2.txt                                          @DataDog/apm-python
.riot/requirements/1f540f4.txt                                          @DataDog/apm-python
.riot/requirements/46e7fca.txt                                          @DataDog/apm-python
.riot/requirements/4ef6c1c.txt                                          @DataDog/apm-python
.riot/requirements/5b09682.txt                                          @DataDog/apm-python
.riot/requirements/a031170.txt                                          @DataDog/apm-python
.riot/requirements/e1faa28.txt                                          @DataDog/apm-python

pr-commenter · 2024-10-22T13:04:49Z

Benchmarks

Benchmark execution time: 2025-02-25 16:39:39

Comparing candidate commit 5d82b9a in PR branch refactor/config-telemetry with baseline commit f76498f in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 418 metrics, 2 unstable metrics.

ensure recursivzely defined envier items are captured in telemetry

mabdinur · 2024-10-22T17:27:33Z

If this change is backported to the 2.15 branch before 2.15.0 is released then a release note is not required.
Otherwise we need to document the fact that v2.15.0 relies on private attributes in a third party library (envier).

cc: @erikayasuda

ddtrace/settings/peer_service.py

tests/telemetry/test_writer.py

ddtrace/settings/dynamic_instrumentation.py

hatch.toml

datadog-dd-trace-py-rkomorn · 2024-10-23T08:45:45Z

Datadog Report

Branch report: refactor/config-telemetry
Commit report: d53d283
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1468 Skipped, 4m 18.66s Total duration (35m 42.64s time saved)

ddtrace/settings/_core.py

ddtrace/settings/peer_service.py

…etry

tests/telemetry/test_writer.py

Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>

add DD_APPSEC_RASP_ENABLED to fix failing test take 3

remove envier from min_compat_version update aws_lambda min version for fix aws_lambda

…etry

github-actions · 2025-02-25T20:12:02Z

The backport to 2.20 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.20 2.20
# Navigate to the new working tree
cd .worktrees/backport-2.20
# Create a new branch
git switch --create backport-11115-to-2.20
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b4f4f623d404bfc7919be2e02ce76282002e244a
# Push it to GitHub
git push --set-upstream origin backport-11115-to-2.20
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.20

Then, create a pull request where the base branch is 2.20 and the compare/head branch is backport-11115-to-2.20.

github-actions · 2025-02-25T20:12:03Z

The backport to 3.0 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-3.0 3.0
# Navigate to the new working tree
cd .worktrees/backport-3.0
# Create a new branch
git switch --create backport-11115-to-3.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b4f4f623d404bfc7919be2e02ce76282002e244a
# Push it to GitHub
git push --set-upstream origin backport-11115-to-3.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-3.0

Then, create a pull request where the base branch is 3.0 and the compare/head branch is backport-11115-to-3.0.

github-actions · 2025-02-25T20:12:04Z

The backport to 2.21 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.21 2.21
# Navigate to the new working tree
cd .worktrees/backport-2.21
# Create a new branch
git switch --create backport-11115-to-2.21
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b4f4f623d404bfc7919be2e02ce76282002e244a
# Push it to GitHub
git push --set-upstream origin backport-11115-to-2.21
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.21

Then, create a pull request where the base branch is 2.21 and the compare/head branch is backport-11115-to-2.21.

github-actions · 2025-02-25T20:12:05Z

The backport to 3.1 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-3.1 3.1
# Navigate to the new working tree
cd .worktrees/backport-3.1
# Create a new branch
git switch --create backport-11115-to-3.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b4f4f623d404bfc7919be2e02ce76282002e244a
# Push it to GitHub
git push --set-upstream origin backport-11115-to-3.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-3.1

Then, create a pull request where the base branch is 3.1 and the compare/head branch is backport-11115-to-3.1.

We refactor the implementation of the telemetry configuration reporting to use new API exposed by the latest release of envier. We also implement a configuration class that automatically reports configuration telemetry after the environment variables have been parsed and validated. - [ ] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [ ] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) --------- Co-authored-by: Munir Abdinur <munir_abdinur@hotmail.com> Co-authored-by: Munir Abdinur <munir.abdinur@datadoghq.com>

…to 3.1) (#12521) We refactor the implementation of the telemetry configuration reporting to use new API exposed by the latest release of envier. We also implement a configuration class that automatically reports configuration telemetry after the environment variables have been parsed and validated. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) Co-authored-by: Gabriele N. Tornetta <P403n1x87@users.noreply.github.com>

We refactor the implementation of the telemetry configuration reporting to use new API exposed by the latest release of envier. We also implement a configuration class that automatically reports configuration telemetry after the environment variables have been parsed and validated. ## Checklist - [ ] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [ ] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) --------- Co-authored-by: Munir Abdinur <munir_abdinur@hotmail.com> Co-authored-by: Munir Abdinur <munir.abdinur@datadoghq.com>

P403n1x87 added the changelog/no-changelog label Oct 22, 2024

P403n1x87 requested a review from mabdinur October 22, 2024 12:26

mabdinur added the [DEPRECATED] backport 2.15 label Oct 22, 2024

mabdinur requested a review from erikayasuda October 22, 2024 14:55

mabdinur force-pushed the refactor/config-telemetry branch 2 times, most recently from f1d768f to d60ed8d Compare October 22, 2024 17:20

fix broken peer service telemetry logic

9bdab98

ensure recursivzely defined envier items are captured in telemetry

mabdinur force-pushed the refactor/config-telemetry branch from d60ed8d to 9bdab98 Compare October 22, 2024 17:21

mabdinur changed the title ~~refactor: configuration telemetry reporting~~ fix: configuration telemetry reporting Oct 22, 2024

mabdinur marked this pull request as ready for review October 22, 2024 17:27

mabdinur requested review from a team as code owners October 22, 2024 17:27

mabdinur reviewed Oct 22, 2024

View reviewed changes

ddtrace/settings/peer_service.py Show resolved Hide resolved

mabdinur reviewed Oct 22, 2024

View reviewed changes

tests/telemetry/test_writer.py Show resolved Hide resolved

mabdinur reviewed Oct 22, 2024

View reviewed changes

tests/telemetry/test_writer.py Outdated Show resolved Hide resolved

Merge branch 'main' into refactor/config-telemetry

6767642

P403n1x87 commented Oct 23, 2024

View reviewed changes

ddtrace/settings/dynamic_instrumentation.py Outdated Show resolved Hide resolved

P403n1x87 commented Oct 23, 2024

View reviewed changes

hatch.toml Show resolved Hide resolved

P403n1x87 commented Oct 23, 2024

View reviewed changes

hatch.toml Show resolved Hide resolved

Update hatch.toml

597e5fb

mabdinur approved these changes Oct 23, 2024

View reviewed changes

erikayasuda approved these changes Oct 25, 2024

View reviewed changes

ddtrace/settings/_core.py Outdated Show resolved Hide resolved

ddtrace/settings/peer_service.py Show resolved Hide resolved

Merge branch 'main' into refactor/config-telemetry

43363d3

P403n1x87 added [DEPRECATED] backport 2.20 [DEPRECATED] backport 3.0 backport 2.21 labels Feb 13, 2025

Merge remote-tracking branch 'origin/main' into refactor/config-telem…

1fcc6b5

…etry

P403n1x87 force-pushed the refactor/config-telemetry branch from 001c613 to 1fcc6b5 Compare February 13, 2025 11:19

brettlangdon reviewed Feb 18, 2025

View reviewed changes

tests/telemetry/test_writer.py Outdated Show resolved Hide resolved

P403n1x87 and others added 3 commits February 18, 2025 16:27

Update tests/telemetry/test_writer.py

fe3a788

Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>

Merge branch 'main' into refactor/config-telemetry

b2f10cd

Merge branch 'main' into refactor/config-telemetry

06243b6

mabdinur force-pushed the refactor/config-telemetry branch from a194897 to 59ad686 Compare February 20, 2025 21:15

mabdinur added 2 commits February 20, 2025 16:16

fix telemetry test

9f878f4

add DD_APPSEC_RASP_ENABLED to fix failing test take 3

fix aws_lambda test: removes old pytest entrypoint

1f86187

remove envier from min_compat_version update aws_lambda min version for fix aws_lambda

mabdinur force-pushed the refactor/config-telemetry branch from 59ad686 to 1f86187 Compare February 20, 2025 21:17

P403n1x87 and others added 3 commits February 21, 2025 14:03

Merge branch 'main' into refactor/config-telemetry

b8469ed

Merge remote-tracking branch 'origin/main' into refactor/config-telem…

818251a

…etry

Merge branch 'main' into refactor/config-telemetry

3bdfa46

P403n1x87 added [DEPRECATED] backport 3.1 and removed [DEPRECATED] backport 2.19 labels Feb 25, 2025

mabdinur and others added 2 commits February 25, 2025 08:45

Merge branch 'main' into refactor/config-telemetry

76b681b

update tests again

5d82b9a

mabdinur merged commit b4f4f62 into main Feb 25, 2025
781 checks passed

mabdinur deleted the refactor/config-telemetry branch February 25, 2025 20:11

adamsxs mentioned this pull request Mar 3, 2025

fix: prevent installation of incompatible envier==0.5.1 (#11286) #12452

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(telemetry): configuration telemetry reporting #11115

chore(telemetry): configuration telemetry reporting #11115

Uh oh!

P403n1x87 commented Oct 22, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Oct 22, 2024 •

edited

Loading

Uh oh!

pr-commenter bot commented Oct 22, 2024 •

edited

Loading

Uh oh!

mabdinur commented Oct 22, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

datadog-dd-trace-py-rkomorn bot commented Oct 23, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 25, 2025

Uh oh!

github-actions bot commented Feb 25, 2025

Uh oh!

github-actions bot commented Feb 25, 2025

Uh oh!

github-actions bot commented Feb 25, 2025

Uh oh!

chore(telemetry): configuration telemetry reporting #11115

chore(telemetry): configuration telemetry reporting #11115

Uh oh!

Conversation

P403n1x87 commented Oct 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Reviewer Checklist

Uh oh!

github-actions bot commented Oct 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pr-commenter bot commented Oct 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Uh oh!

mabdinur commented Oct 22, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

datadog-dd-trace-py-rkomorn bot commented Oct 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Datadog Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 25, 2025

Uh oh!

github-actions bot commented Feb 25, 2025

Uh oh!

github-actions bot commented Feb 25, 2025

Uh oh!

github-actions bot commented Feb 25, 2025

Uh oh!

P403n1x87 commented Oct 22, 2024 •

edited

Loading

github-actions bot commented Oct 22, 2024 •

edited

Loading

pr-commenter bot commented Oct 22, 2024 •

edited

Loading

datadog-dd-trace-py-rkomorn bot commented Oct 23, 2024 •

edited

Loading